From: Simon Horman <horms@verge.net.au>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, makita.toshiaki@lab.ntt.co.jp,
kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan
Date: Wed, 3 Jun 2015 10:09:08 +0900 [thread overview]
Message-ID: <20150603010908.GE30703@verge.net.au> (raw)
In-Reply-To: <20150601.145625.1435351866234972759.davem@davemloft.net>
On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 01 Jun 2015 07:12:37 -0700
>
> > Can we ensure offload_base contains a sensible order of expected
> > types ?
>
> This seemed easy enough to kill, so I pushed the following into net-next:
>
> ====================
> [PATCH] net: Add priority to packet_offload objects.
>
> When we scan a packet for GRO processing, we want to see the most
> common packet types in the front of the offload_base list.
>
> So add a priority field so we can handle this properly.
>
> IPv4/IPv6 get the highest priority with the implicit zero priority
> field.
>
> Next comes ethernet with a priority of 10, and then we have the MPLS
> types with a priority of 15.
FWIW I have no objections to the priority assigned to MPLS.
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
> Suggested-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> Signed-off-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2015-06-03 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:55 [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan Toshiaki Makita
2015-06-01 14:12 ` Eric Dumazet
2015-06-01 16:03 ` Toshiaki Makita
2015-06-01 16:28 ` Eric Dumazet
2015-06-01 21:56 ` David Miller
2015-06-03 1:09 ` Simon Horman [this message]
2015-06-01 23:51 ` David Miller
2015-06-02 1:24 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603010908.GE30703@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).