From: Jiri Benc <jbenc@redhat.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: netdev@vger.kernel.org, pshelar@nicira.com, jesse@nicira.com,
davem@davemloft.net, daniel@iogearbox.net, dev@openvswitch.org,
tom@herbertland.com, edumazet@google.com, jiri@resnulli.us,
hannes@stressinduktion.org, marcelo.leitner@gmail.com,
stephen@networkplumber.org, jpettit@nicira.com, kaber@trash.net
Subject: Re: [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action
Date: Wed, 3 Jun 2015 17:29:35 +0200 [thread overview]
Message-ID: <20150603172935.2a019653@griffin> (raw)
In-Reply-To: <13ac5a4837771ff2f52aa685f526b04c1ed76b86.1433167296.git.tgraf@suug.ch>
On Mon, 1 Jun 2015 16:27:32 +0200, Thomas Graf wrote:
> --- a/net/openvswitch/flow.h
> +++ b/net/openvswitch/flow.h
> @@ -45,6 +45,11 @@ struct sk_buff;
> #define TUN_METADATA_OPTS(flow_key, opt_len) \
> ((void *)((flow_key)->tun_opts + TUN_METADATA_OFFSET(opt_len)))
>
> +struct ovs_tunnel_info
> +{
> + struct ip_tunnel_info *info;
> +};
Why do you keep this structure? It doesn't seem it's useful.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-06-03 15:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:27 [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices Thomas Graf
2015-06-01 14:27 ` [net-next RFC 01/14] ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic Thomas Graf
2015-06-01 14:27 ` [net-next RFC 02/14] ip_tunnel: support per packet tunnel metadata Thomas Graf
2015-06-01 14:27 ` [net-next RFC 03/14] vxlan: Flow based tunneling Thomas Graf
2015-06-01 14:27 ` [net-next RFC 04/14] route: Extend flow representation with tunnel key Thomas Graf
2015-06-01 14:27 ` [net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL Thomas Graf
2015-06-01 16:51 ` Robert Shearman
[not found] ` <556C8D95.7030008-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-06-01 23:26 ` Thomas Graf
2015-06-01 14:27 ` [net-next RFC 06/14] fib: Add fib rule match on tunnel id Thomas Graf
2015-06-01 14:27 ` [net-next RFC 07/14] vxlan: Factor out device configuration Thomas Graf
2015-06-01 14:27 ` [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action Thomas Graf
2015-06-03 15:29 ` Jiri Benc [this message]
2015-06-03 22:07 ` Thomas Graf
2015-06-01 14:27 ` [net-next RFC 09/14] openvswitch: Move dev pointer into vport itself Thomas Graf
2015-06-01 14:27 ` [net-next RFC 11/14] openvswitch: Use regular VXLAN net_device device Thomas Graf
2015-06-01 14:27 ` [net-next RFC 12/14] vxlan: remove indirect call to vxlan_rcv() and vni member Thomas Graf
2015-06-01 14:27 ` [net-next RFC 13/14] openvswitch: Use regular GRE net_device instead of vport Thomas Graf
2015-06-01 14:27 ` [net-next RFC 14/14] arp: Associate ARP requests with tunnel info Thomas Graf
2015-06-02 17:52 ` [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices Flavio Leitner
[not found] ` <cover.1433167295.git.tgraf-G/eBtMaohhA@public.gmane.org>
2015-06-01 14:27 ` [net-next RFC 10/14] openvswitch: Abstract vport name through ovs_vport_name() Thomas Graf
2015-06-02 19:02 ` [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603172935.2a019653@griffin \
--to=jbenc@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=jpettit@nicira.com \
--cc=kaber@trash.net \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).