Re: [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action

From: Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>
To: Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
	marcelo.leitner-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org,
	daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org,
	stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org,
	hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org,
	tom-BjP2VixgY4xUbtYUoyoikg@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action
Date: Thu, 4 Jun 2015 00:07:57 +0200	[thread overview]
Message-ID: <20150603220757.GA687@pox.localdomain> (raw)
In-Reply-To: <20150603172935.2a019653@griffin>

On 06/03/15 at 05:29pm, Jiri Benc wrote:
> On Mon,  1 Jun 2015 16:27:32 +0200, Thomas Graf wrote:
> > --- a/net/openvswitch/flow.h
> > +++ b/net/openvswitch/flow.h
> > @@ -45,6 +45,11 @@ struct sk_buff;
> >  #define TUN_METADATA_OPTS(flow_key, opt_len) \
> >  	((void *)((flow_key)->tun_opts + TUN_METADATA_OFFSET(opt_len)))
> >  
> > +struct ovs_tunnel_info
> > +{
> > +	struct ip_tunnel_info	*info;
> > +};
> 
> Why do you keep this structure? It doesn't seem it's useful.

It's the structure which defines the payload of the OVS set
tunnel action. Those actions are configured as Netlink attributes
only visible to the kernel. Since we allocate the ip_tunnel_info
to attach it to the packets passing by, we only need to keep a
pointer as the config to the set action. We could also do
(struct ip_tunnel_info *) nla_data(...) and store the pointer
without defining a struct. I found this more readable. Happy to
change if you like it better without a struct around it.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev