From: David Miller <davem@davemloft.net>
To: shawn.bohrer@gmail.com
Cc: netdev@vger.kernel.org, Yurij.Plotnikov@oktetlabs.ru,
Alexandra.Kossovsky@oktetlabs.ru, eric.dumazet@gmail.com,
oliver.e.graff@gmail.com, sergei.shtylyov@cogentembedded.com,
sbohrer@rgmadvisors.com
Subject: Re: [PATCH v2] ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()
Date: Thu, 04 Jun 2015 00:46:58 -0700 (PDT) [thread overview]
Message-ID: <20150604.004658.541562931844276343.davem@davemloft.net> (raw)
In-Reply-To: <1433366858-14317-1-git-send-email-shawn.bohrer@gmail.com>
From: Shawn Bohrer <shawn.bohrer@gmail.com>
Date: Wed, 3 Jun 2015 16:27:38 -0500
> From: Shawn Bohrer <sbohrer@rgmadvisors.com>
>
> 421b3885bf6d56391297844f43fb7154a6396e12 "udp: ipv4: Add udp early
> demux" introduced a regression that allowed sockets bound to INADDR_ANY
> to receive packets from multicast groups that the socket had not joined.
> For example a socket that had joined 224.168.2.9 could also receive
> packets from 225.168.2.9 despite not having joined that group if
> ip_early_demux is enabled.
>
> Fix this by calling ip_check_mc_rcu() in udp_v4_early_demux() to verify
> that the multicast packet is indeed ours.
>
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
> Reported-by: Yurij M. Plotnikov <Yurij.Plotnikov@oktetlabs.ru>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-06-04 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 16:38 Socket receives packet to multicast group to which it was not joined since kernel 3.13.10-1 Yurij M. Plotnikov
2014-05-12 17:18 ` Eric Dumazet
2014-05-13 6:25 ` Yurij M. Plotnikov
2014-05-13 21:36 ` Shawn Bohrer
2014-05-14 20:40 ` Shawn Bohrer
2015-05-24 4:55 ` Oliver Graff
2015-05-26 17:41 ` Shawn Bohrer
2015-05-26 17:59 ` Eric Dumazet
2015-06-01 16:34 ` [PATCH] ipv4/udp: Verify multicast group is ours in upd_v4_early_demux() Shawn Bohrer
2015-06-01 20:11 ` Sergei Shtylyov
2015-06-03 21:27 ` [PATCH v2] " Shawn Bohrer
2015-06-04 7:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604.004658.541562931844276343.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Alexandra.Kossovsky@oktetlabs.ru \
--cc=Yurij.Plotnikov@oktetlabs.ru \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.e.graff@gmail.com \
--cc=sbohrer@rgmadvisors.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=shawn.bohrer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).