* [PATCH] b44: call netif_napi_del()
@ 2015-06-06 21:22 Hauke Mehrtens
2015-06-07 7:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2015-06-06 21:22 UTC (permalink / raw)
To: zambrano, davem; +Cc: netdev, Hauke Mehrtens
When the driver gets unregistered a call to netif_napi_del() was
missing.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/ethernet/broadcom/b44.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index 77363d6..ebb9910 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -2480,6 +2480,7 @@ static void b44_remove_one(struct ssb_device *sdev)
b44_unregister_phy_one(bp);
ssb_device_disable(sdev, 0);
ssb_bus_may_powerdown(sdev->bus);
+ netif_napi_del(&bp->napi);
free_netdev(dev);
ssb_pcihost_set_power_state(sdev, PCI_D3hot);
ssb_set_drvdata(sdev, NULL);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] b44: call netif_napi_del()
2015-06-06 21:22 [PATCH] b44: call netif_napi_del() Hauke Mehrtens
@ 2015-06-07 7:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-07 7:09 UTC (permalink / raw)
To: hauke; +Cc: zambrano, netdev
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat, 6 Jun 2015 23:22:46 +0200
> When the driver gets unregistered a call to netif_napi_del() was
> missing.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This patch is incomplete.
All of that failure paths in b44_init_one() after the netif_napi_add()
call have the same exact bug.
Please fix those too and resubmit.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-07 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-06 21:22 [PATCH] b44: call netif_napi_del() Hauke Mehrtens
2015-06-07 7:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).