[PATCH] b44: call netif_napi_del()

[PATCH] b44: call netif_napi_del()

[Hauke Mehrtens]

When the driver gets unregistered a call to netif_napi_del() was
missing.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/ethernet/broadcom/b44.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index 77363d6..ebb9910 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -2480,6 +2480,7 @@ static void b44_remove_one(struct ssb_device *sdev)
 		b44_unregister_phy_one(bp);
 	ssb_device_disable(sdev, 0);
 	ssb_bus_may_powerdown(sdev->bus);
+	netif_napi_del(&bp->napi);
 	free_netdev(dev);
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
 	ssb_set_drvdata(sdev, NULL);
-- 
2.1.4

Re: [PATCH] b44: call netif_napi_del()

[David Miller]

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat,  6 Jun 2015 23:22:46 +0200

> When the driver gets unregistered a call to netif_napi_del() was
> missing.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

This patch is incomplete.

All of that failure paths in b44_init_one() after the netif_napi_add()
call have the same exact bug.

Please fix those too and resubmit.

Thanks.