* [PATCH net] amd-xgbe: Use disable_irq_nosync from within timer function
@ 2015-06-05 21:02 Tom Lendacky
2015-06-07 7:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tom Lendacky @ 2015-06-05 21:02 UTC (permalink / raw)
To: netdev; +Cc: David Miller
Since the Tx timer function runs in softirq context the driver needs
to call disable_irq_nosync instead of a disable_irq.
Reported-by: Josh Stone <jistone@redhat.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index db84ddc..9fd6c69 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -423,7 +423,7 @@ static void xgbe_tx_timer(unsigned long data)
if (napi_schedule_prep(napi)) {
/* Disable Tx and Rx interrupts */
if (pdata->per_channel_irq)
- disable_irq(channel->dma_irq);
+ disable_irq_nosync(channel->dma_irq);
else
xgbe_disable_rx_tx_ints(pdata);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] amd-xgbe: Use disable_irq_nosync from within timer function
2015-06-05 21:02 [PATCH net] amd-xgbe: Use disable_irq_nosync from within timer function Tom Lendacky
@ 2015-06-07 7:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-07 7:21 UTC (permalink / raw)
To: thomas.lendacky; +Cc: netdev
From: Tom Lendacky <thomas.lendacky@amd.com>
Date: Fri, 5 Jun 2015 16:02:26 -0500
> Since the Tx timer function runs in softirq context the driver needs
> to call disable_irq_nosync instead of a disable_irq.
>
> Reported-by: Josh Stone <jistone@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Applied, thanks Tom.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-07 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 21:02 [PATCH net] amd-xgbe: Use disable_irq_nosync from within timer function Tom Lendacky
2015-06-07 7:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).