From: David Miller <davem@davemloft.net>
To: julien.grall@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
david.vrabel@citrix.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses
Date: Sun, 07 Jun 2015 02:00:05 -0700 (PDT) [thread overview]
Message-ID: <20150607.020005.1921032930953172020.davem@davemloft.net> (raw)
In-Reply-To: <1433432114-22198-2-git-send-email-julien.grall@citrix.com>
From: Julien Grall <julien.grall@citrix.com>
Date: Thu, 4 Jun 2015 16:35:13 +0100
> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
>
> Also use %d rather than %x for rx->offset.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: netdev@vger.kernel.org
>
> ---
> Changes in v3:
> - Use %d for the rx-offset too.
This change in v3 is wrong, 'rx->offset' is unsigned therefore %u is
the correct format string to use.
next prev parent reply other threads:[~2015-06-07 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 15:35 [PATCH v3 0/2] net/xen: Clean up Julien Grall
2015-06-04 15:35 ` [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-07 9:00 ` David Miller [this message]
2015-06-04 15:35 ` [PATCH v3 2/2] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607.020005.1921032930953172020.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=julien.grall@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).