From: Firo Yang <firogm@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fib_trie: Fix potential null pointer dereference
Date: Sun, 7 Jun 2015 21:42:11 +0800 [thread overview]
Message-ID: <20150607134211.GA16700@firo> (raw)
In-Reply-To: <alpine.DEB.2.10.1506071520410.2716@hadrien>
On Sun, Jun 07, 2015 at 03:23:57PM +0200, Julia Lawall wrote:
>> >I think that many people would make the same mistake when looking at the
>> >code. The change doesn't seem to hurt anything?
>> Actually, yes. But it does imporve nothing but coding style.
>> I think Alexander's code style make function more compact is also a
>> good code style. So, just keep it original.
>
>Still it makes noise when other people look at the code and find that it
>looks odd. Removing the false positive in smatch won't completely help,
>because people could look at the code for other reasons.
You said it! I will do the improvement.
Firo
>
>But, as you like.
>
>julia
--
next prev parent reply other threads:[~2015-06-07 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 11:35 [PATCH] fib_trie: Fix potential null pointer dereference Firo Yang
2015-06-06 12:05 ` Eric Dumazet
2015-06-07 3:20 ` Alexander Duyck
[not found] ` <5573B7A2.4010607@gmail.com>
2015-06-07 4:46 ` Firo Yang
2015-06-07 6:01 ` Firo Yang
2015-06-07 6:36 ` Julia Lawall
2015-06-07 13:19 ` Firo Yang
2015-06-07 13:23 ` Julia Lawall
2015-06-07 13:42 ` Firo Yang [this message]
2015-06-07 16:36 ` Alexander Duyck
2015-06-06 13:39 ` walter harms
2015-06-07 4:52 ` Firo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607134211.GA16700@firo \
--to=firogm@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=julia.lawall@lip6.fr \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).