From: David Miller <davem@davemloft.net>
To: johunt@akamai.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
sergei.shtylyov@cogentembedded.com, tom@herbertland.com
Subject: Re: [PATCH v3] ipv6: Fix protocol resubmission
Date: Mon, 08 Jun 2015 12:16:01 -0700 (PDT) [thread overview]
Message-ID: <20150608.121601.1357405469784892473.davem@davemloft.net> (raw)
In-Reply-To: <1433779259-14328-1-git-send-email-johunt@akamai.com>
From: Josh Hunt <johunt@akamai.com>
Date: Mon, 8 Jun 2015 12:00:59 -0400
> UDP encapsulation is broken on IPv6. This is because the logic to resubmit
> the nexthdr is inverted, checking for a ret value > 0 instead of < 0. Also,
> the resubmit label is in the wrong position since we already get the
> nexthdr value when performing decapsulation. In addition the skb pull is no
> longer necessary either.
>
> This changes the return value check to look for < 0, using it for the
> nexthdr on the next iteration, and moves the resubmit label to the proper
> location.
>
> With these changes the v6 code now matches what we do in the v4 ip input
> code wrt resubmitting when decapsulating.
>
> Signed-off-by: Josh Hunt <johunt@akamai.com>
Applied.
next prev parent reply other threads:[~2015-06-08 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 16:00 [PATCH v3] ipv6: Fix protocol resubmission Josh Hunt
2015-06-08 16:10 ` Tom Herbert
2015-06-08 19:16 ` David Miller [this message]
2015-06-10 4:24 ` Hajime Tazaki
2015-06-10 4:53 ` YOSHIFUJI Hideaki
2015-06-10 13:22 ` Josh Hunt
2015-06-10 15:16 ` YOSHIFUJI Hideaki
2015-06-10 15:23 ` Josh Hunt
2015-06-10 15:53 ` Josh Hunt
2015-06-10 21:57 ` Josh Hunt
2015-06-10 22:30 ` David Miller
2015-06-11 13:05 ` Hajime Tazaki
2015-06-11 15:32 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608.121601.1357405469784892473.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tom@herbertland.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).