netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hyong-Youb Kim <hykim@myri.com>
To: anna <zy900702@163.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: PROBLEM: there exists a wrong return value of function myri10ge_probe()
Date: Tue, 9 Jun 2015 20:52:44 +0900	[thread overview]
Message-ID: <20150609115242.GA3732@hykim-PC> (raw)
In-Reply-To: <39f5faaa.db15.14dd801ed14.Coremail.zy900702@163.com>

On Tue, Jun 09, 2015 at 07:08:34PM +0800, anna wrote:
[...]
> mgp->sram_size satisfy the condition in line 4062, the value of
> status is 0. So the function myri10ge_probe() will return 0 to
> its caller functions when it runs error, leading to a wrong
> return value of function myri10ge_probe().

Okay, that is a bug.  I will try to prepare a patch.  Is this a real
problem for you (i.e. your setup is tripping this bug), or a
theoretical one you found via scripts or something?  If it is a real
problem, can you give me more context (e.g. NIC model, firmware
version)?

Also, I am going to need a proper "your name <address>", unless you do
not want your name in the patch.

           reply	other threads:[~2015-06-09 12:09 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <39f5faaa.db15.14dd801ed14.Coremail.zy900702@163.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609115242.GA3732@hykim-PC \
    --to=hykim@myri.com \
    --cc=netdev@vger.kernel.org \
    --cc=zy900702@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).