From: David Miller <davem@davemloft.net>
To: _govind@gmx.com
Cc: netdev@vger.kernel.org, ssujith@cisco.com, benve@cisco.com
Subject: Re: [PATCH net 3/3] enic: fix memory leak in rq_clean
Date: Wed, 10 Jun 2015 23:43:22 -0700 (PDT) [thread overview]
Message-ID: <20150610.234322.1344906421619743139.davem@davemloft.net> (raw)
In-Reply-To: <1434003776-31840-3-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Thu, 11 Jun 2015 11:52:56 +0530
> When incoming packet qualifies for rx_copybreak, we copy the data to newly
> allocated skb. We do not free/unmap the original buffer. At this point driver
> assumes this buffer is unallocated. When enic_rq_alloc_buf() is called for
> buffer allocation, it checks if buf->os_buf is NULL. If its not NULL that means
> buffer can be re-used.
>
> When vnic_rq_clean() is called for freeing all rq buffers, and if the
> rx_copybreak reused buffer falls outside the used desc, we do not free the
> buffer. The following trace is observer when dma-debug is enabled.
>
> Fix is to walk through complete ring and clean if buffer is present.
...
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied.
next prev parent reply other threads:[~2015-06-11 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 6:22 [PATCH net 1/3] enic: unlock napi busy poll before unmasking intr Govindarajulu Varadarajan
2015-06-11 6:22 ` [PATCH net 2/3] enic: check return value for stat dump Govindarajulu Varadarajan
2015-06-11 6:43 ` David Miller
2015-06-11 6:22 ` [PATCH net 3/3] enic: fix memory leak in rq_clean Govindarajulu Varadarajan
2015-06-11 6:43 ` David Miller [this message]
2015-06-11 6:43 ` [PATCH net 1/3] enic: unlock napi busy poll before unmasking intr David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610.234322.1344906421619743139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).