From: David Miller <davem@davemloft.net>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us, f.fainelli@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops
Date: Wed, 10 Jun 2015 23:56:49 -0700 (PDT) [thread overview]
Message-ID: <20150610.235649.1747681763810479422.davem@davemloft.net> (raw)
In-Reply-To: <1433981089-51216-1-git-send-email-sfeldma@gmail.com>
From: sfeldma@gmail.com
Date: Wed, 10 Jun 2015 17:04:49 -0700
> From: Scott Feldman <sfeldma@gmail.com>
>
> If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement
> support for IPv4 FIB add/del ops, don't fail route add/del offload
> operations. Route adds will not be marked as OFFLOAD. Routes will be
> installed in the kernel FIB, as usual.
>
> This was report/fixed by Florian when testing DSA driver with net-next on
> devices with L2 offload support but no L3 offload support. What he reported
> was an initial route installed from DHCP client would fail (route not
> installed to kernel FIB). This was triggering the setting of
> ipv4.fib_offload_disabled, which would disable route offloading after the
> first failure. So subsequent attempts to install the route would succeed.
>
> There is follow-on work/discussion to address the handling of route install
> failures, but for now, let's differentiate between no support and failed
> support.
>
> Reported-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2015-06-11 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 0:04 [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops sfeldma
2015-06-11 0:03 ` Florian Fainelli
2015-06-11 6:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610.235649.1747681763810479422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).