* [PATCH 1/1 linux-next] vxge: use swap() in vxge_hw_channel_dtr_alloc()
@ 2015-06-10 16:33 Fabian Frederick
2015-06-11 22:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-06-10 16:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Julia Lawall, Fabian Frederick, Jon Mason, netdev
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/neterion/vxge/vxge-traffic.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
index 9e1aaa7..5f630a2 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
@@ -1004,8 +1004,6 @@ void vxge_hw_device_clear_tx_rx(struct __vxge_hw_device *hldev)
static enum vxge_hw_status
vxge_hw_channel_dtr_alloc(struct __vxge_hw_channel *channel, void **dtrh)
{
- void **tmp_arr;
-
if (channel->reserve_ptr - channel->reserve_top > 0) {
_alloc_after_swap:
*dtrh = channel->reserve_arr[--channel->reserve_ptr];
@@ -1020,10 +1018,7 @@ _alloc_after_swap:
* i.e. no additional lock need to be done when we free a resource */
if (channel->length - channel->free_ptr > 0) {
-
- tmp_arr = channel->reserve_arr;
- channel->reserve_arr = channel->free_arr;
- channel->free_arr = tmp_arr;
+ swap(channel->reserve_arr, channel->free_arr);
channel->reserve_ptr = channel->length;
channel->reserve_top = channel->free_ptr;
channel->free_ptr = channel->length;
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] vxge: use swap() in vxge_hw_channel_dtr_alloc()
2015-06-10 16:33 [PATCH 1/1 linux-next] vxge: use swap() in vxge_hw_channel_dtr_alloc() Fabian Frederick
@ 2015-06-11 22:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-11 22:21 UTC (permalink / raw)
To: fabf; +Cc: linux-kernel, Julia.Lawall, jdmason, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Wed, 10 Jun 2015 18:33:26 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-11 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 16:33 [PATCH 1/1 linux-next] vxge: use swap() in vxge_hw_channel_dtr_alloc() Fabian Frederick
2015-06-11 22:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).