From: David Miller <davem@davemloft.net>
To: mleitner@redhat.com
Cc: netdev@vger.kernel.org, nhorman@tuxdriver.com,
linux-sctp@vger.kernel.org, vyasevich@gmail.com
Subject: Re: [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO
Date: Fri, 12 Jun 2015 14:18:55 -0700 (PDT) [thread overview]
Message-ID: <20150612.141855.497341688044235937.davem@davemloft.net> (raw)
In-Reply-To: <ca8fca62141ed9e108170919cdc12bdb09cdda73.1434043704.git.marcelo.leitner@gmail.com>
From: mleitner@redhat.com
Date: Thu, 11 Jun 2015 14:49:46 -0300
> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>
> Currently, we can ask to authenticate DATA chunks and we can send DATA
> chunks on the same packet as COOKIE_ECHO, but if you try to combine
> both, the DATA chunk will be sent unauthenticated and peer won't accept
> it, leading to a communication failure.
>
> This happens because even though the data was queued after it was
> requested to authenticate DATA chunks, it was also queued before we
> could know that remote peer can handle authenticating, so
> sctp_auth_send_cid() returns false.
>
> The fix is whenever we set up an active key, re-check send queue for
> chunks that now should be authenticated. As a result, such packet will
> now contain COOKIE_ECHO + AUTH + DATA chunks, in that order.
>
> Reported-by: Liu Wei <weliu@redhat.com>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2015-06-12 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 17:49 [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO mleitner
2015-06-12 0:27 ` David Miller
2015-06-12 11:26 ` Neil Horman
2015-06-12 17:24 ` Vlad Yasevich
2015-06-12 21:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612.141855.497341688044235937.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).