* [BUG ?] delay always evaluates to 0
@ 2015-06-12 16:58 Nicholas Mc Guire
2015-06-15 12:38 ` Stanislav Yakovlev
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-06-12 16:58 UTC (permalink / raw)
To: Stanislav Yakovlev
Cc: Kalle Valo, James Ketrenos, linux-wireless, netdev, linux-kernel
Hi !
commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511
1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv)
1411 {
1412
1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
1414
...
1437
1438 schedule_timeout_uninterruptible(HW_PHY_OFF_LOOP_DELAY);
1439 }
but (HZ / 5000) will evaluate to 0 for all configurable HZ values - typo ?
and this schedule_timeout_uninterruptible() is probably not doing what
is intended.
thx!
hofrat
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG ?] delay always evaluates to 0
2015-06-12 16:58 [BUG ?] delay always evaluates to 0 Nicholas Mc Guire
@ 2015-06-15 12:38 ` Stanislav Yakovlev
2015-06-15 17:38 ` Nicholas Mc Guire
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Yakovlev @ 2015-06-15 12:38 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Kalle Valo, James Ketrenos, wireless, netdev, linux-kernel
Hi Nicholas,
On 12 June 2015 at 20:58, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> Hi !
>
> commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
>
> drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511
> 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv)
> 1411 {
> 1412
> 1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
> 1414
> ...
> 1437
> 1438 schedule_timeout_uninterruptible(HW_PHY_OFF_LOOP_DELAY);
> 1439 }
>
> but (HZ / 5000) will evaluate to 0 for all configurable HZ values - typo ?
> and this schedule_timeout_uninterruptible() is probably not doing what
> is intended.
Yes, you are right. This is a bug. I think it should be:
-#define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
+#define HW_PHY_OFF_LOOP_DELAY (msecs_to_jiffies(50))
Will you send us a patch?
Stanislav.
>
> thx!
> hofrat
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG ?] delay always evaluates to 0
2015-06-15 12:38 ` Stanislav Yakovlev
@ 2015-06-15 17:38 ` Nicholas Mc Guire
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-06-15 17:38 UTC (permalink / raw)
To: Stanislav Yakovlev
Cc: Kalle Valo, James Ketrenos, wireless, netdev, linux-kernel
On Mon, 15 Jun 2015, Stanislav Yakovlev wrote:
> Hi Nicholas,
>
> On 12 June 2015 at 20:58, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > Hi !
> >
> > commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
> >
> > drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511
> > 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv)
> > 1411 {
> > 1412
> > 1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
> > 1414
> > ...
> > 1437
> > 1438 schedule_timeout_uninterruptible(HW_PHY_OFF_LOOP_DELAY);
> > 1439 }
> >
> > but (HZ / 5000) will evaluate to 0 for all configurable HZ values - typo ?
> > and this schedule_timeout_uninterruptible() is probably not doing what
> > is intended.
>
> Yes, you are right. This is a bug. I think it should be:
>
> -#define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
> +#define HW_PHY_OFF_LOOP_DELAY (msecs_to_jiffies(50))
>
> Will you send us a patch?
>
just sent it out - thanks!
hofrat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-15 17:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-12 16:58 [BUG ?] delay always evaluates to 0 Nicholas Mc Guire
2015-06-15 12:38 ` Stanislav Yakovlev
2015-06-15 17:38 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).