* [BUG ?] rtlwifi: rtl8723be: condition with no effect
@ 2015-06-13 10:43 Nicholas Mc Guire
2015-06-14 15:17 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-06-13 10:43 UTC (permalink / raw)
To: Larry Finger
Cc: Chaoming Li, Kalle Valo, John W. Linville, Jiri Kosina,
Randy Dunlap, Masanari Iida,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
WARNING: condition with no effect (if branch == else)
Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'
drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
886 if (thermalvalue > rtlefuse->eeprom_thermalmeter)
887 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
888 index_for_channel);
889 else
890 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
891 index_for_channel);
Can't figure out what the intent of this condition is but it currently has
no effect as if == else and this most likely is not the intent.
thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG ?] rtlwifi: rtl8723be: condition with no effect
2015-06-13 10:43 [BUG ?] rtlwifi: rtl8723be: condition with no effect Nicholas Mc Guire
@ 2015-06-14 15:17 ` Larry Finger
[not found] ` <557D9B09.7020100-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2015-06-14 15:17 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Chaoming Li, Kalle Valo, John W. Linville, Jiri Kosina,
Randy Dunlap, Masanari Iida, linux-wireless, netdev, linux-kernel
On 06/13/2015 05:43 AM, Nicholas Mc Guire wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
>
> scanning for trivial bug-patters with coccinelle spatches returned:
> ./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
> WARNING: condition with no effect (if branch == else)
>
> Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'
>
> drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
> 886 if (thermalvalue > rtlefuse->eeprom_thermalmeter)
> 887 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 888 index_for_channel);
> 889 else
> 890 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 891 index_for_channel);
>
> Can't figure out what the intent of this condition is but it currently has
> no effect as if == else and this most likely is not the intent.
I do not know what the correct code should be here, but I will contact the
Realtek engineers and get their interpretation. In the meantime, please do not
change this code.
Thanks,
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG ?] rtlwifi: rtl8723be: condition with no effect
[not found] ` <557D9B09.7020100-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
@ 2015-06-14 15:46 ` Nicholas Mc Guire
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-06-14 15:46 UTC (permalink / raw)
To: Larry Finger
Cc: Nicholas Mc Guire, Chaoming Li, Kalle Valo, John W. Linville,
Jiri Kosina, Randy Dunlap, Masanari Iida,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sun, 14 Jun 2015, Larry Finger wrote:
> On 06/13/2015 05:43 AM, Nicholas Mc Guire wrote:
>> From: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
>>
>> scanning for trivial bug-patters with coccinelle spatches returned:
>> ./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
>> WARNING: condition with no effect (if branch == else)
>>
>> Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'
>>
>> drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
>> 886 if (thermalvalue > rtlefuse->eeprom_thermalmeter)
>> 887 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
>> 888 index_for_channel);
>> 889 else
>> 890 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
>> 891 index_for_channel);
>>
>> Can't figure out what the intent of this condition is but it currently has
>> no effect as if == else and this most likely is not the intent.
>
> I do not know what the correct code should be here, but I will contact
> the Realtek engineers and get their interpretation. In the meantime,
> please do not change this code.
>
as noted - I have no clue - so no intent to attempt a change
my mail is only intended as probable bug report.
thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-14 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-13 10:43 [BUG ?] rtlwifi: rtl8723be: condition with no effect Nicholas Mc Guire
2015-06-14 15:17 ` Larry Finger
[not found] ` <557D9B09.7020100-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-06-14 15:46 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).