* [PATCH net-next] sfc: mark state UNINIT after unregister
@ 2015-06-15 17:27 Edward Cree
2015-06-16 2:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Edward Cree @ 2015-06-15 17:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
Without this change, modprobe -r sfc hits the BUG_ON() in
efx_pci_remove_main().
Fixes: e7fef9b45ae1 ("sfc: add sysfs entry to control MCDI tracing")
Reported-by: Jarod Wilson <jarod@redhat.com>
Reviewed-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
drivers/net/ethernet/sfc/efx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 0c42ed9..67bdaf3 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2920,6 +2920,7 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
efx_dissociate(efx);
dev_close(efx->net_dev);
efx_disable_interrupts(efx);
+ efx->state = STATE_UNINIT;
rtnl_unlock();
if (efx->type->sriov_fini)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sfc: mark state UNINIT after unregister
2015-06-15 17:27 [PATCH net-next] sfc: mark state UNINIT after unregister Edward Cree
@ 2015-06-16 2:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-16 2:55 UTC (permalink / raw)
To: ecree; +Cc: netdev, linux-net-drivers
From: Edward Cree <ecree@solarflare.com>
Date: Mon, 15 Jun 2015 18:27:54 +0100
> Without this change, modprobe -r sfc hits the BUG_ON() in
> efx_pci_remove_main().
>
> Fixes: e7fef9b45ae1 ("sfc: add sysfs entry to control MCDI tracing")
> Reported-by: Jarod Wilson <jarod@redhat.com>
> Reviewed-by: Jarod Wilson <jarod@redhat.com>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-16 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-15 17:27 [PATCH net-next] sfc: mark state UNINIT after unregister Edward Cree
2015-06-16 2:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).