From: David Miller <davem@davemloft.net>
To: fabf@skynet.be
Cc: linux-kernel@vger.kernel.org, chien.yen@oracle.com,
rds-devel@oss.oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] net: rds: use for_each_sg() for scatterlist parsing
Date: Mon, 15 Jun 2015 19:56:30 -0700 (PDT) [thread overview]
Message-ID: <20150615.195630.111617476194185511.davem@davemloft.net> (raw)
In-Reply-To: <1434388385-29246-1-git-send-email-fabf@skynet.be>
From: Fabian Frederick <fabf@skynet.be>
Date: Mon, 15 Jun 2015 19:13:05 +0200
> {
> unsigned int i;
> + struct scatterlist *sg;
Please order local variables from longest to shortest line (reverse
christmas tree).
Thanks.
prev parent reply other threads:[~2015-06-16 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 17:13 [PATCH 1/1 net-next] net: rds: use for_each_sg() for scatterlist parsing Fabian Frederick
2015-06-16 2:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615.195630.111617476194185511.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chien.yen@oracle.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).