From: Nicholas Mc Guire <der.herr@hofr.at>
To: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
James Ketrenos <jketreno@linux.intel.com>,
wireless <linux-wireless@vger.kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG ?] delay always evaluates to 0
Date: Mon, 15 Jun 2015 19:38:25 +0200 [thread overview]
Message-ID: <20150615173825.GC31859@opentech.at> (raw)
In-Reply-To: <CA++WF2NoEAhRKnOXtC_C=JfmvZU=WuPEKZ3Zs2KxdHwBtHhHFg@mail.gmail.com>
On Mon, 15 Jun 2015, Stanislav Yakovlev wrote:
> Hi Nicholas,
>
> On 12 June 2015 at 20:58, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > Hi !
> >
> > commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
> >
> > drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511
> > 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv)
> > 1411 {
> > 1412
> > 1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
> > 1414
> > ...
> > 1437
> > 1438 schedule_timeout_uninterruptible(HW_PHY_OFF_LOOP_DELAY);
> > 1439 }
> >
> > but (HZ / 5000) will evaluate to 0 for all configurable HZ values - typo ?
> > and this schedule_timeout_uninterruptible() is probably not doing what
> > is intended.
>
> Yes, you are right. This is a bug. I think it should be:
>
> -#define HW_PHY_OFF_LOOP_DELAY (HZ / 5000)
> +#define HW_PHY_OFF_LOOP_DELAY (msecs_to_jiffies(50))
>
> Will you send us a patch?
>
just sent it out - thanks!
hofrat
prev parent reply other threads:[~2015-06-15 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 16:58 [BUG ?] delay always evaluates to 0 Nicholas Mc Guire
2015-06-15 12:38 ` Stanislav Yakovlev
2015-06-15 17:38 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615173825.GC31859@opentech.at \
--to=der.herr@hofr.at \
--cc=jketreno@linux.intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).