From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH 4/7] slub: fix error path bug in kmem_cache_alloc_bulk Date: Wed, 17 Jun 2015 08:25:31 +0200 Message-ID: <20150617082531.33eb524c@redhat.com> References: <20150615155053.18824.617.stgit@devil> <20150615155226.18824.99.stgit@devil> <20150616145109.5bbe850094519072d33e9047@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-mm@kvack.org, Christoph Lameter , netdev@vger.kernel.org, Alexander Duyck , brouer@redhat.com To: Andrew Morton Return-path: In-Reply-To: <20150616145109.5bbe850094519072d33e9047@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Tue, 16 Jun 2015 14:51:09 -0700 Andrew Morton wrote: > On Mon, 15 Jun 2015 17:52:26 +0200 Jesper Dangaard Brouer wrote: > > > The current kmem_cache/SLAB bulking API need to release all objects > > in case the layer cannot satisfy the full request. > > > > If __kmem_cache_alloc_bulk() fails, all allocated objects in array > > should be freed, but, __kmem_cache_alloc_bulk() can't know > > about objects allocated by this slub specific kmem_cache_alloc_bulk() > > function. > > Can we fold patches 2, 3 and 4 into a single patch? > > And maybe patch 5 as well. I don't think we need all these > development-time increments in the permanent record. I agree. I'll fold them when submitting V2 -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org