* [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().
@ 2015-06-18 11:40 Hiroaki Shimoda
2015-06-19 6:42 ` Eric Dumazet
2015-06-23 8:20 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Hiroaki Shimoda @ 2015-06-18 11:40 UTC (permalink / raw)
To: davem; +Cc: netdev
inet_diag_dump_reqs() is called from inet_diag_dump_icsk() with BH
disabled. So no need to disable BH in inet_diag_dump_reqs().
Signed-off-by: Hiroaki Shimoda <shimoda.hiroaki@gmail.com>
---
net/ipv4/inet_diag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index 21985d8d41e7..4ca789ba63cb 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -746,7 +746,7 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
entry.family = sk->sk_family;
- spin_lock_bh(&icsk->icsk_accept_queue.syn_wait_lock);
+ spin_lock(&icsk->icsk_accept_queue.syn_wait_lock);
lopt = icsk->icsk_accept_queue.listen_opt;
if (!lopt || !listen_sock_qlen(lopt))
@@ -794,7 +794,7 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
}
out:
- spin_unlock_bh(&icsk->icsk_accept_queue.syn_wait_lock);
+ spin_unlock(&icsk->icsk_accept_queue.syn_wait_lock);
return err;
}
--
2.3.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().
2015-06-18 11:40 [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs() Hiroaki Shimoda
@ 2015-06-19 6:42 ` Eric Dumazet
2015-06-19 10:34 ` Hiroaki Shimoda
2015-06-23 8:20 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2015-06-19 6:42 UTC (permalink / raw)
To: Hiroaki Shimoda; +Cc: davem, netdev
On Thu, 2015-06-18 at 20:40 +0900, Hiroaki Shimoda wrote:
> inet_diag_dump_reqs() is called from inet_diag_dump_icsk() with BH
> disabled. So no need to disable BH in inet_diag_dump_reqs().
>
> Signed-off-by: Hiroaki Shimoda <shimoda.hiroaki@gmail.com>
> ---
> net/ipv4/inet_diag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
> index 21985d8d41e7..4ca789ba63cb 100644
> --- a/net/ipv4/inet_diag.c
> +++ b/net/ipv4/inet_diag.c
> @@ -746,7 +746,7 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
>
> entry.family = sk->sk_family;
>
> - spin_lock_bh(&icsk->icsk_accept_queue.syn_wait_lock);
> + spin_lock(&icsk->icsk_accept_queue.syn_wait_lock);
>
> lopt = icsk->icsk_accept_queue.listen_opt;
> if (!lopt || !listen_sock_qlen(lopt))
> @@ -794,7 +794,7 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
> }
>
> out:
> - spin_unlock_bh(&icsk->icsk_accept_queue.syn_wait_lock);
> + spin_unlock(&icsk->icsk_accept_queue.syn_wait_lock);
>
> return err;
> }
Sure, although this will soon be removed completely when SYN_RECV
sockets will be stored in regular ehash table.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().
2015-06-18 11:40 [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs() Hiroaki Shimoda
2015-06-19 6:42 ` Eric Dumazet
@ 2015-06-23 8:20 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-06-23 8:20 UTC (permalink / raw)
To: shimoda.hiroaki; +Cc: netdev
From: Hiroaki Shimoda <shimoda.hiroaki@gmail.com>
Date: Thu, 18 Jun 2015 20:40:54 +0900
> inet_diag_dump_reqs() is called from inet_diag_dump_icsk() with BH
> disabled. So no need to disable BH in inet_diag_dump_reqs().
>
> Signed-off-by: Hiroaki Shimoda <shimoda.hiroaki@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-23 8:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-18 11:40 [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs() Hiroaki Shimoda
2015-06-19 6:42 ` Eric Dumazet
2015-06-19 10:34 ` Hiroaki Shimoda
2015-06-23 8:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).