From: "J. Bruce Fields" <bfields@fieldses.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()
Date: Fri, 19 Jun 2015 15:52:51 -0400 [thread overview]
Message-ID: <20150619195251.GD21903@fieldses.org> (raw)
In-Reply-To: <1434484672-5877-1-git-send-email-fabf@skynet.be>
Thanks, applying.--b.
On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote:
> Don't opencode sg_init_one()
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index b5408e8..fee3c15 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -881,9 +881,7 @@ krb5_rc4_setup_seq_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
> if (err)
> goto out_err;
>
> - sg_init_table(sg, 1);
> - sg_set_buf(sg, &zeroconstant, 4);
> -
> + sg_init_one(sg, &zeroconstant, 4);
> err = crypto_hash_digest(&desc, sg, 4, Kseq);
> if (err)
> goto out_err;
> @@ -951,9 +949,7 @@ krb5_rc4_setup_enc_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
> if (err)
> goto out_err;
>
> - sg_init_table(sg, 1);
> - sg_set_buf(sg, zeroconstant, 4);
> -
> + sg_init_one(sg, zeroconstant, 4);
> err = crypto_hash_digest(&desc, sg, 4, Kcrypt);
> if (err)
> goto out_err;
> --
> 2.4.2
prev parent reply other threads:[~2015-06-19 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:57 [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key() Fabian Frederick
2015-06-19 19:52 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619195251.GD21903@fieldses.org \
--to=bfields@fieldses.org \
--cc=anna.schumaker@netapp.com \
--cc=davem@davemloft.net \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).