From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Nimrod Andy <B38611@freescale.com>,
Duan Andy <fugang.duan@freescale.com>,
Cory Tusar <cory.tusar@pid1solutions.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus
Date: Sat, 20 Jun 2015 19:58:17 +0200 [thread overview]
Message-ID: <20150620175817.GA9863@lunn.ch> (raw)
In-Reply-To: <CAOMZO5Bb2i2Xr2-+6pNSy5WHxh1FK3utB3-VqS6X-_OK=+t82g@mail.gmail.com>
On Sat, Jun 20, 2015 at 02:47:20PM -0300, Fabio Estevam wrote:
> On Sat, Jun 20, 2015 at 1:15 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > @@ -1764,6 +1765,11 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
> > {
> > struct fec_enet_private *fep = bus->priv;
> > unsigned long time_left;
> > + int ret;
> > +
> > + ret = clk_prepare_enable(fep->clk_ipg);
> > + if (ret)
> > + return 0xffff;
>
> Why don`t you return ret instead?
ret would also work.
v3 to follow soon.
Andrew
next prev parent reply other threads:[~2015-06-20 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 16:15 [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus Andrew Lunn
2015-06-20 17:47 ` Fabio Estevam
2015-06-20 17:58 ` Andrew Lunn [this message]
2015-06-21 1:01 ` Florian Fainelli
2015-06-21 20:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620175817.GA9863@lunn.ch \
--to=andrew@lunn.ch \
--cc=B38611@freescale.com \
--cc=cory.tusar@pid1solutions.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).