From: David Miller <davem@davemloft.net>
To: fransklaver@gmail.com
Cc: al.drozdov@gmail.com, maninder1.s@samsung.com,
willemb@google.com, dborkman@redhat.com, viro@zeniv.linux.org.uk,
eyal.birger@gmail.com, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, pankaj.m@samsung.com
Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON
Date: Sun, 21 Jun 2015 09:55:17 -0700 (PDT) [thread overview]
Message-ID: <20150621.095517.1714979384853036107.davem@davemloft.net> (raw)
In-Reply-To: <CAH6sp9PzTkNd88+ExRX1FTNNC=wC+jjOdL5urmtoyc5iz-pZTQ@mail.gmail.com>
From: Frans Klaver <fransklaver@gmail.com>
Date: Wed, 17 Jun 2015 10:30:18 +0200
> Ah, that explains something. If retire timer is not going to be needed
> for tx, wouldn't it be better to remove the whole tx_ring handling
> from this function altogether, rather than changing the BUG()?
Agreed.
prev parent reply other threads:[~2015-06-21 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 4:36 [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON Maninder Singh
2015-06-17 6:28 ` Michael S. Tsirkin
2015-06-17 7:36 ` Frans Klaver
2015-06-17 8:26 ` Alexander Drozdov
2015-06-17 8:30 ` Frans Klaver
2015-06-21 16:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621.095517.1714979384853036107.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=al.drozdov@gmail.com \
--cc=dborkman@redhat.com \
--cc=eyal.birger@gmail.com \
--cc=fransklaver@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).