From: David Miller <davem@davemloft.net>
To: gospo@cumulusnetworks.com
Cc: netdev@vger.kernel.org, ddutt@cumulusnetworks.com,
sfeldma@gmail.com, alexander.duyck@gmail.com,
hannes@stressinduktion.org, stephen@networkplumber.org
Subject: Re: [PATCH net-next 1/3 v5] net: track link-status of ipv4 nexthops
Date: Tue, 23 Jun 2015 02:30:40 -0700 (PDT) [thread overview]
Message-ID: <20150623.023040.2256044180311272935.davem@davemloft.net> (raw)
In-Reply-To: <1434640932-2681-2-git-send-email-gospo@cumulusnetworks.com>
From: Andy Gospodarek <gospo@cumulusnetworks.com>
Date: Thu, 18 Jun 2015 11:22:10 -0400
> - ((nh->nh_flags ^ onh->nh_flags) & ~RTNH_F_DEAD))
> + ((nh->nh_flags ^ onh->nh_flags) & ~(RTNH_F_COMPARE_MASK)))
> return -1;
Excessive parenthesis, just plain "~RTNH_F_COMPARE_MASK" is sufficient.
> + if (linkdown == fi->fib_nhs) {
> + fi->fib_flags |= RTNH_F_LINKDOWN;
> + }
Single line basic blocks do not get enclosing curly braces.
next prev parent reply other threads:[~2015-06-23 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 15:22 [PATCH net-next 0/3 v5] changes to make ipv4 routing table aware of next-hop link status Andy Gospodarek
2015-06-18 15:22 ` [PATCH net-next 1/3 v5] net: track link-status of ipv4 nexthops Andy Gospodarek
2015-06-23 9:30 ` David Miller [this message]
2015-06-23 11:59 ` Andy Gospodarek
2015-06-18 15:22 ` [PATCH net-next 2/3 v5] net: ipv4 sysctl option to ignore routes when nexthop link is down Andy Gospodarek
2015-06-18 15:22 ` [PATCH net-next 3/3 v5] iproute2: add support to print 'linkdown' nexthop flag Andy Gospodarek
2015-06-18 15:43 ` Scott Feldman
2015-06-18 15:57 ` Andy Gospodarek
2015-06-18 16:00 ` Scott Feldman
2015-06-18 17:51 ` [PATCH net-next 0/3 v5] changes to make ipv4 routing table aware of next-hop link status Scott Feldman
2015-06-18 19:39 ` Andy Gospodarek
2015-06-21 5:34 ` Scott Feldman
2015-06-21 5:36 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623.023040.2256044180311272935.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=ddutt@cumulusnetworks.com \
--cc=gospo@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).