From: David Miller <davem@davemloft.net>
To: imrep.amz@gmail.com
Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com,
wei.liu2@citrix.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imrep@amazon.de, msw@amazon.com
Subject: Re: [PATCH] xen-netback: fix a BUG() during initialization
Date: Tue, 23 Jun 2015 03:34:36 -0700 (PDT) [thread overview]
Message-ID: <20150623.033436.27435944821901354.davem@davemloft.net> (raw)
In-Reply-To: <1434716511-25657-1-git-send-email-imrep.amz@gmail.com>
From: Imre Palik <imrep.amz@gmail.com>
Date: Fri, 19 Jun 2015 14:21:51 +0200
> From: "Palik, Imre" <imrep@amazon.de>
>
> Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime settable")
> introduced the capability to change the bandwidth rate limit at runtime.
> But it also introduced a possible crashing bug.
>
> If netback receives two XenbusStateConnected without getting the
> hotplug-status watch firing in between, then it will try to register the
> watches for the rate limiter again. But this triggers a BUG() in the watch
> registration code.
>
> The fix modifies connect() to remove the possibly existing packet-rate
> watches before trying to install those watches. This behaviour is in line
> with how connect() deals with the hotplug-status watch.
>
> Signed-off-by: Imre Palik <imrep@amazon.de>
> Cc: Matt Wilson <msw@amazon.com>
Applied, thank you.
prev parent reply other threads:[~2015-06-23 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 12:21 [PATCH] xen-netback: fix a BUG() during initialization Imre Palik
2015-06-19 15:37 ` Wei Liu
2015-06-23 10:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623.033436.27435944821901354.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=imrep.amz@gmail.com \
--cc=imrep@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).