netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: geert+renesas@glider.be
Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry
Date: Wed, 24 Jun 2015 00:55:37 -0700 (PDT)	[thread overview]
Message-ID: <20150624.005537.1031818561162918702.davem@davemloft.net> (raw)
In-Reply-To: <1435064462-11680-1-git-send-email-geert+renesas@glider.be>

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Tue, 23 Jun 2015 15:01:01 +0200

> Since commit 05104c266ae9a167 ("ARM: shmobile: r7s72100: genmai: Remove
> legacy board file"), r7s72100 is only supported in generic DT-only ARM
> multi-platform builds.  The driver doesn't need to match platform
> devices by name anymore, hence remove the corresponding
> platform_device_id entry.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

These two changes are incomplete, please compile test your changes and
look for warnings:

drivers/net/ethernet/renesas/sh_eth.c:493:31: warning: ‘r8a779x_data’ defined but not used [-Wunused-variable]
drivers/net/ethernet/renesas/sh_eth.c:803:31: warning: ‘r7s72100_data’ defined but not used [-Wunused-variable]

  parent reply	other threads:[~2015-06-24  7:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 13:01 [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry Geert Uytterhoeven
2015-06-23 13:01 ` [PATCH 2/2] sh_eth: Remove obsolete r8a779x-ether platform_device_id entries Geert Uytterhoeven
2015-06-23 23:50   ` Simon Horman
2015-06-23 23:49 ` [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry Simon Horman
2015-06-24  7:55 ` David Miller [this message]
2015-06-24  7:48   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624.005537.1031818561162918702.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=geert+renesas@glider.be \
    --cc=linux-sh@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).