* [patch -next] renesas: missing unlock on error path
@ 2015-06-24 14:32 Dan Carpenter
2015-06-24 16:53 ` Sergei Shtylyov
2015-06-25 9:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-06-24 14:32 UTC (permalink / raw)
To: Masaru Nagai; +Cc: Masaru Nagai, Sergei Shtylyov, netdev, kernel-janitors
We need to unlock before returning here.
Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c
index 42656da..7a8ce92 100644
--- a/drivers/net/ethernet/renesas/ravb_ptp.c
+++ b/drivers/net/ethernet/renesas/ravb_ptp.c
@@ -116,8 +116,10 @@ static int ravb_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
priv->ptp.current_addend = addend;
gccr = ravb_read(ndev, GCCR);
- if (gccr & GCCR_LTI)
+ if (gccr & GCCR_LTI) {
+ spin_unlock_irqrestore(&priv->lock, flags);
return -EBUSY;
+ }
ravb_write(ndev, addend & GTI_TIV, GTI);
ravb_write(ndev, gccr | GCCR_LTI, GCCR);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch -next] renesas: missing unlock on error path
2015-06-24 14:32 [patch -next] renesas: missing unlock on error path Dan Carpenter
@ 2015-06-24 16:53 ` Sergei Shtylyov
2015-06-25 9:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-06-24 16:53 UTC (permalink / raw)
To: Dan Carpenter, Masaru Nagai; +Cc: netdev, kernel-janitors
Hello.
On 06/24/2015 05:32 PM, Dan Carpenter wrote:
> We need to unlock before returning here.
Indeed. Sorry about missing that.
> Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch -next] renesas: missing unlock on error path
2015-06-24 14:32 [patch -next] renesas: missing unlock on error path Dan Carpenter
2015-06-24 16:53 ` Sergei Shtylyov
@ 2015-06-25 9:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-06-25 9:13 UTC (permalink / raw)
To: dan.carpenter; +Cc: masaru.nagai.vx, sergei.shtylyov, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 24 Jun 2015 17:32:54 +0300
> We need to unlock before returning here.
>
> Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-25 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 14:32 [patch -next] renesas: missing unlock on error path Dan Carpenter
2015-06-24 16:53 ` Sergei Shtylyov
2015-06-25 9:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).