From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error Date: Fri, 26 Jun 2015 17:04:01 +0200 Message-ID: <20150626150401.GH9469@lunn.ch> References: <1435240213-15179-1-git-send-email-giladb@ezchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, Gilad Ben-Yossef , Florian Fainelli , Guenter Roeck , Scott Feldman To: giladb@ezchip.com Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:58383 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbbFZPKD (ORCPT ); Fri, 26 Jun 2015 11:10:03 -0400 Content-Disposition: inline In-Reply-To: <1435240213-15179-1-git-send-email-giladb@ezchip.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jun 25, 2015 at 04:50:13PM +0300, giladb@ezchip.com wrote: > From: Gilad Ben-Yossef > > DSA master netdev promiscuity counter was not being properly > decremented on slave device open error path. > > Signed-off-by: Gilad Ben-Yossef > CC: Gilad Ben-Yossef > CC: David S. Miller > CC: Florian Fainelli > CC: Guenter Roeck > CC: Andrew Lunn > CC: Scott Feldman Hi Gilad Acked-by: Andrew Lunn FYI: I grep'ed the whole kernel. This seems to be the only place 0 is passed to dev_set_promiscuity(), i.e. the same bug is not present anywhere else. Thanks Andrew > --- > net/dsa/slave.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 04ffad3..0917123 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev) > > clear_promisc: > if (dev->flags & IFF_PROMISC) > - dev_set_promiscuity(master, 0); > + dev_set_promiscuity(master, -1); > clear_allmulti: > if (dev->flags & IFF_ALLMULTI) > dev_set_allmulti(master, -1); > -- > 1.7.1 >