public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bastian Bittorf <bittorf@bluebottle.com>
Cc: netdev@vger.kernel.org, Vadim Kochan <vadim4j@gmail.com>
Subject: Re: iproute2 / question: returncode when query a match
Date: Fri, 26 Jun 2015 15:30:49 -0700	[thread overview]
Message-ID: <20150626153049.74d86f33@urahara> (raw)
In-Reply-To: <20150626073145.GU5927@medion.lan>

On Fri, 26 Jun 2015 09:31:45 +0200
Bastian Bittorf <bittorf@bluebottle.com> wrote:

> * Vadim Kochan <vadim4j@gmail.com> [15.06.2015 18:36]:
> > > root@box:~ ip route list exact '0.0.0.0/8'
> > > root@box:~ echo $?
> > > 0
> > > 
> > > i expected an RC of != 0 when there is no match.
> > > is this by design?
> > > 
> > > root@box:~ ip -V
> > > ip utility, iproute2-ss4.0.0-1-openwrt
> > 
> > I think that RC != 0 only in case error happened, but may be its good
> > idea to add such behaviour or add option to consider ret code
> > if there is no results ?
> 
> ofcourse this is only useful for scripting:
> 
> # ip route list exact '0.0.0.0/8' || do_some_action
> 
> instead of the now used construct:
> # [ -n "$( ip route list exact '0.0.0.0/8' )" ] || do_some_action
> 
> i'am sure there are other queries, where this also
> makes sense. there are 2 possible ways for implementing this IMHO:
> 
> introduce a commandlineswitch like --pedantic
> or just always throw an error 1 when there is no match like this:
> 
> root@box:~ echo foo | grep bar
> root@box:~ echo $?
> 1
> 
> more opinions about that?
> 
> bye, bastian

Exit codes for ip route are already used to handle errors.
See current man page.

If you want to handle both errors and no match, the scripting tricks
to look for empty output are better.

      reply	other threads:[~2015-06-26 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04  8:16 iproute2 / question: returncode when query a match Bastian Bittorf
     [not found] ` <20150614162616.GA25952@angus-think.lan>
2015-06-26  7:31   ` Bastian Bittorf
2015-06-26 22:30     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626153049.74d86f33@urahara \
    --to=stephen@networkplumber.org \
    --cc=bittorf@bluebottle.com \
    --cc=netdev@vger.kernel.org \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox