From: Andrew Lunn <andrew@lunn.ch>
To: Duan Andy <fugang.duan@freescale.com>
Cc: netdev <netdev@vger.kernel.org>,
Cory Tusar <cory.tusar@pid1solutions.com>
Subject: Re: [RFC PATCHv4] net: fec: Ensure clocks are enabled while using mdio bus
Date: Mon, 29 Jun 2015 05:44:02 +0200 [thread overview]
Message-ID: <20150629034402.GA30187@lunn.ch> (raw)
In-Reply-To: <BLUPR03MB373F2684A8C9BF38719B930F5AA0@BLUPR03MB373.namprd03.prod.outlook.com>
> > @@ -3496,10 +3523,11 @@ static int __maybe_unused fec_suspend(struct
> > device *dev)
> > netif_device_detach(ndev);
> > netif_tx_unlock_bh(ndev);
> > fec_stop(ndev);
> > - fec_enet_clk_enable(ndev, false);
> > if (!(fep->wol_flag & FEC_WOL_FLAG_ENABLE))
> > pinctrl_pm_select_sleep_state(&fep->pdev->dev);
> > }
> > +
> > + fec_enet_clk_enable(ndev, false);
>
> Why do you move out the api from netif runnig condition ?
Ah, read the documentation again. I see my error. I thought it would
call fec_suspend() and fec_resume(). But now i see there are separate
runtime suspend and resume functions.
I will fix this.
Andrew
prev parent reply other threads:[~2015-06-29 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 17:36 [RFC PATCHv4] net: fec: Ensure clocks are enabled while using mdio bus Andrew Lunn
2015-06-29 2:04 ` Duan Andy
2015-06-29 3:44 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629034402.GA30187@lunn.ch \
--to=andrew@lunn.ch \
--cc=cory.tusar@pid1solutions.com \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).