From: Stephen Hemminger <stephen@networkplumber.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h
Date: Mon, 29 Jun 2015 14:55:48 -1000 [thread overview]
Message-ID: <20150629145548.4169cf9d@uryu.home.lan> (raw)
In-Reply-To: <20150629180720.GA22584@salvia>
On Mon, 29 Jun 2015 20:07:20 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Jun 25, 2015 at 11:12:06PM -0400, Stephen Hemminger wrote:
> > This fixes breakage to iproute2 build with recent kernel headers
> > caused by:
> > commit a263653ed798216c0069922d7b5237ca49436007
> > Author: Pablo Neira Ayuso <pablo@netfilter.org>
> > Date: Wed Jun 17 10:28:27 2015 -0500
> >
> > netfilter: don't pull include/linux/netfilter.h from netns headers
> >
> > The issue is that definitions in linux/in.h overlap with those
> > in netinet/in.h. This patch solves this by introducing the same
> > mechanism as was used to solve the same problem with linux/in6.h
>
> My patch also modifies non-exposed net/netns/ headers, I'm not sure
> how this can be causing problems to uapi headers.
The problem is that your patch changes include/uapi/linux/netfilter.h
to include linux/in.h. Some programs have already include <netinet/in.h>
(often through a complex chain of headers).
If both headers are included it causes errors and warnings about duplicate
definitions. My patch fixes that.
prev parent reply other threads:[~2015-06-30 0:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 3:12 [PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h Stephen Hemminger
2015-06-27 21:52 ` David Miller
2015-06-27 23:20 ` David Miller
2015-06-29 18:07 ` Pablo Neira Ayuso
2015-06-30 0:55 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629145548.4169cf9d@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).