netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Caller or callee setting skb->network_header?
@ 2015-06-30  2:01 Linus Lüssing
  0 siblings, 0 replies; only message in thread
From: Linus Lüssing @ 2015-06-30  2:01 UTC (permalink / raw)
  To: b.a.t.m.a.n, netdev

Hi,

For an .ndo_start_xmit handler, can the callee rely on the caller
setting the skb network header?

Or should the callee set it before performing any
skb_network_header()/ip_hdr()/ipv6_hdr()/... calls?

Cheers, Linus

PS: Currently looking at batman-adv's ndo_start_xmit handler
"interface_tx()", whether an skb_set_network_header() should be
added there as it uses ip_hdr()/ipv6_hdr() later
(-> batadv_mcast_forw_mode_check_ipv{4,6}()). Testing this in
VMs it seemed to be set correctly by the caller, but wanted to
check whether this can or shouldn't be relied on.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-06-30  2:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30  2:01 Caller or callee setting skb->network_header? Linus Lüssing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).