From: Thomas Graf <tgraf@suug.ch>
To: Meelis Roos <mroos@linux.ee>
Cc: sparclinux@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Daniel Borkmann <daniel@iogearbox.net>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: 4.1 regression in resizable hashtable tests
Date: Thu, 2 Jul 2015 14:31:30 +0200 [thread overview]
Message-ID: <20150702123130.GA20843@pox.localdomain> (raw)
In-Reply-To: <alpine.LRH.2.11.1507011259180.4092@math.ut.ee>
On 07/01/15 at 01:21pm, Meelis Roos wrote:
> This is 4.1 on sparc64 - one of my boxes that happens to have most
> runtime test left on from some debugging effort. In 4.0 it was fine, 4.1
> gives this in dmesg:
>
> [ 31.898697] Running resizable hashtable tests...
> [ 31.898915] Adding 2048 keys
> [ 31.952911] Traversal complete: counted=17, nelems=2048, entries=2048
> [ 31.953004] Test failed: Total count mismatch ^^^
> [ 32.022676] Traversal complete: counted=17, nelems=2048, entries=2048
> [ 32.022788] Test failed: Total count mismatch ^^^
> [ 32.022828] Deleting 2048 keys
Thanks for the report. I think this is already fixed. Can you try with the
following commit:
commit 246b23a7695bd5a457aa51a36a948cce53d1d477
Author: Thomas Graf <tgraf@suug.ch>
Date: Thu Apr 30 22:37:44 2015 +0000
rhashtable-test: Use walker to test bucket statistics
As resizes may continue to run in the background, use walker to
ensure we see all entries. Also print the encountered number
of rehashes queued up while traversing.
This may lead to warnings due to entries being seen multiple
times. We consider them non-fatal.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2015-07-02 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 10:21 4.1 regression in resizable hashtable tests Meelis Roos
2015-07-02 12:31 ` Thomas Graf [this message]
2015-07-02 19:09 ` Meelis Roos
2015-07-17 8:04 ` Thomas Graf
2015-07-17 10:26 ` Phil Sutter
2015-07-17 10:29 ` Phil Sutter
2015-07-17 10:31 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702123130.GA20843@pox.localdomain \
--to=tgraf@suug.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox