From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org,
Mitch Williams <mitch.a.williams@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Jiri Pirko <jiri@resnulli.us>, Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO
Date: Thu, 2 Jul 2015 10:23:00 -0600 [thread overview]
Message-ID: <20150702162300.GA4642@obsidianresearch.com> (raw)
In-Reply-To: <5593B48F.2060403@iogearbox.net>
On Wed, Jul 01, 2015 at 11:36:15AM +0200, Daniel Borkmann wrote:
> Hi Jason,
>
> On 07/01/2015 12:52 AM, Jason Gunthorpe wrote:
> >It turns out the policy was defined but never actually checked,
> >so lets check it.
> >
> >Fixes: ebc08a6f47ee ("rtnetlink: Add VF config code to rtnetlink")
>
> I would argue that the actual commit would be ...
>
> Fixes: c02db8c6290b ("rtnetlink: make SR-IOV VF interface symmetric")
Yes, agree
> So, commit c02db8c6290b moved it into a nested attribute (IFLA_VF_INFO)
> where we indeed don't do further validation. Imho, we should pass the
> parsed attribute table from nla_parse_nested() down into do_setvfinfo(),
> something like the below; I can give it a test run on my ixgbe.
Yes, that is saner overall
Jason
prev parent reply other threads:[~2015-07-02 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 22:52 [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO Jason Gunthorpe
2015-07-01 9:36 ` Daniel Borkmann
2015-07-02 8:34 ` Daniel Borkmann
2015-07-02 23:06 ` Jason Gunthorpe
2015-07-03 21:52 ` Daniel Borkmann
2015-07-02 16:23 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702162300.GA4642@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=chrisw@sous-sol.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@resnulli.us \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).