From: Thomas Graf <tgraf@suug.ch>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: ebiederm@xmission.com, rshearma@brocade.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Summary lightweight tunnel discussion at NFWS
Date: Fri, 3 Jul 2015 12:00:23 +0200 [thread overview]
Message-ID: <20150703100023.GH26182@pox.localdomain> (raw)
In-Reply-To: <1434689355-4088-3-git-send-email-roopa@cumulusnetworks.com>
On 06/18/15 at 09:49pm, Roopa Prabhu wrote:
> +#ifdef CONFIG_LWTUNNEL
> + if (fi->fib_nh->nh_lwtstate) {
> + struct lwtunnel_state *lwtstate;
> +
> + lwtstate = fi->fib_nh->nh_lwtstate;
> + if (nla_put_u16(skb, RTA_ENCAP_TYPE, lwtstate->type))
> + goto nla_put_failure;
> + lwtunnel_fill_encap(skb, lwtstate);
> + }
> }
> +#endif
Misplaced #endif ;-)
Other than that I managed to rebase my changes onto yours and it
looks clean.
Since we also discussed this a bit at NFWS, I'm enclosing a quick
summary:
* Overall consensus that a lightweight flow based encapsulation
makes sense.
* Realization that what we actually want is stackable skb metadata
between layers without over engineering it.
* Consensus to avoid adding it to skb_shared_info and try to reuse
the skb dst field.
* New dst_metadata type similar to xfrm_dst which can carry metadata
such as encapsulation instructions/information.
* Can be made stackable to implement nested encapsulation if needed.
Left out in the beginning to keep it simple.
* Possible optimization option by putting the dst_metadata into a
per cpu scratch buffer or stack without taking a reference and
only force the reference & allocation when the skb is about to
be queued. The regular fast path should never queue a skb with
dst metadata attached.
next prev parent reply other threads:[~2015-07-03 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes Roopa Prabhu
2015-06-19 6:59 ` Julian Anastasov
2015-06-19 14:19 ` roopa
2015-06-19 14:55 ` Robert Shearman
2015-06-19 15:15 ` roopa
2015-06-19 15:19 ` Robert Shearman
2015-06-19 15:28 ` roopa
2015-06-19 17:17 ` Robert Shearman
2015-06-19 18:42 ` roopa
2015-06-21 20:20 ` Thomas Graf
2015-06-22 2:30 ` roopa
2015-07-03 10:00 ` Thomas Graf [this message]
2015-07-05 6:21 ` Summary lightweight tunnel discussion at NFWS roopa
2015-07-06 13:03 ` Thomas Graf
2015-07-06 15:24 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703100023.GH26182@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).