netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] NET: hamradio: Fix IP over bpq encapsulation.
@ 2015-07-04  9:22 Ralf Baechle
  2015-07-08 21:09 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2015-07-04  9:22 UTC (permalink / raw)
  To: David S. Miller, netdev, linux-hams, stable, Eric W. Biederman

Since 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic
neighbour cache operations.) any attempt to transmit IP packets over
a bpqether device will result in a message like "Dead loop on virtual
device bpq0, fix it urgently!"

Fix suggested by Eric W. Biederman <ebiederm@xmission.com>.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Cc: <stable@vger.kernel.org> # 4.1
---
 drivers/net/hamradio/bpqether.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index 63ff08a..5b54b18 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -483,6 +483,7 @@ static void bpq_setup(struct net_device *dev)
 	memcpy(dev->dev_addr,  &ax25_defaddr, AX25_ADDR_LEN);
 
 	dev->flags      = 0;
+	dev->features	= NETIF_F_LLTX;	/* Allow recursion */
 
 #if defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE)
 	dev->header_ops      = &ax25_header_ops;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] NET: hamradio: Fix IP over bpq encapsulation.
  2015-07-04  9:22 [PATCH] NET: hamradio: Fix IP over bpq encapsulation Ralf Baechle
@ 2015-07-08 21:09 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-08 21:09 UTC (permalink / raw)
  To: ralf; +Cc: netdev, linux-hams, stable, ebiederm

From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 4 Jul 2015 11:22:30 +0200

> Since 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic
> neighbour cache operations.) any attempt to transmit IP packets over
> a bpqether device will result in a message like "Dead loop on virtual
> device bpq0, fix it urgently!"
> 
> Fix suggested by Eric W. Biederman <ebiederm@xmission.com>.
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> Cc: <stable@vger.kernel.org> # 4.1

Applied, thanks Ralf.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-08 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-04  9:22 [PATCH] NET: hamradio: Fix IP over bpq encapsulation Ralf Baechle
2015-07-08 21:09 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).