From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: davem@davemloft.net, claudiu.manoil@freescale.com,
haokexin@gmail.com, matei.pavaluca@freescale.com,
jingchang.lu@freescale.com, tobias@waldekranz.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] freescale:Make the function gfar_configure_coalescing_all static
Date: Tue, 7 Jul 2015 21:53:17 +0200 [thread overview]
Message-ID: <20150707195317.GJ9671@pengutronix.de> (raw)
In-Reply-To: <1436298573-28541-1-git-send-email-xerofoify@gmail.com>
On Tue, Jul 07, 2015 at 03:49:33PM -0400, Nicholas Krause wrote:
> This makes the function gfar_configure_coalescing_all static
> and removes its function prototype from the header file, gianfar.h
really? Looking at the diffstat I dare to disagree.
> due to this function only ever being called in its definition and
> declaration file of gainfar.c.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/freescale/gianfar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next parent reply other threads:[~2015-07-07 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1436298573-28541-1-git-send-email-xerofoify@gmail.com>
2015-07-07 19:53 ` Uwe Kleine-König [this message]
[not found] <1436300035-26092-1-git-send-email-xerofoify@gmail.com>
2015-07-08 7:40 ` [PATCH] freescale:Make the function gfar_configure_coalescing_all static Manoil Claudiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707195317.GJ9671@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=haokexin@gmail.com \
--cc=jingchang.lu@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matei.pavaluca@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).