* Re: [PATCH] freescale:Make the function gfar_configure_coalescing_all static
[not found] <1436298573-28541-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-07 19:53 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2015-07-07 19:53 UTC (permalink / raw)
To: Nicholas Krause
Cc: davem, claudiu.manoil, haokexin, matei.pavaluca, jingchang.lu,
tobias, netdev, linux-kernel
On Tue, Jul 07, 2015 at 03:49:33PM -0400, Nicholas Krause wrote:
> This makes the function gfar_configure_coalescing_all static
> and removes its function prototype from the header file, gianfar.h
really? Looking at the diffstat I dare to disagree.
> due to this function only ever being called in its definition and
> declaration file of gainfar.c.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/freescale/gianfar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] freescale:Make the function gfar_configure_coalescing_all static
[not found] <1436300035-26092-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-08 7:40 ` Manoil Claudiu
0 siblings, 0 replies; 2+ messages in thread
From: Manoil Claudiu @ 2015-07-08 7:40 UTC (permalink / raw)
To: Nicholas Krause, davem@davemloft.net; +Cc: netdev@vger.kernel.org
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Tuesday, July 07, 2015 11:14 PM
> To: davem@davemloft.net
> Cc: Manoil Claudiu-B08782; haokexin@gmail.com;
> matei.pavaluca@freescale.com; u.kleine-koenig@pengutronix.de;
> jingchang.lu@freescale.com; tobias@waldekranz.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] freescale:Make the function gfar_configure_coalescing_all
> static
>
Ditto, "gianfar: [...]" in the subject.
I could incorporate this to my set of patches I'm planning to send soon.
Claudiu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-08 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1436298573-28541-1-git-send-email-xerofoify@gmail.com>
2015-07-07 19:53 ` [PATCH] freescale:Make the function gfar_configure_coalescing_all static Uwe Kleine-König
[not found] <1436300035-26092-1-git-send-email-xerofoify@gmail.com>
2015-07-08 7:40 ` Manoil Claudiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).