* [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG
@ 2015-07-05 17:16 Rob Herring
2015-07-06 17:19 ` Florian Fainelli
2015-07-08 21:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2015-07-05 17:16 UTC (permalink / raw)
To: Florian Fainelli; +Cc: netdev, Rob Herring, David S. Miller
On UML builds, mdio-mux-mmioreg.c fails to compile:
drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
This is due to CONFIG_OF now being user selectable. Add a dependency on
HAS_IOMEM to fix this.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
---
drivers/net/phy/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index cf18940..cb86d7a 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
config MDIO_BUS_MUX_MMIOREG
tristate "Support for MMIO device-controlled MDIO bus multiplexers"
- depends on OF_MDIO
+ depends on OF_MDIO && HAS_IOMEM
select MDIO_BUS_MUX
help
This module provides a driver for MDIO bus multiplexers that
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG
2015-07-05 17:16 [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG Rob Herring
@ 2015-07-06 17:19 ` Florian Fainelli
2015-07-08 21:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2015-07-06 17:19 UTC (permalink / raw)
To: Rob Herring; +Cc: netdev, David S. Miller
2015-07-05 10:16 GMT-07:00 Rob Herring <robh@kernel.org>:
> On UML builds, mdio-mux-mmioreg.c fails to compile:
>
> drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>
> This is due to CONFIG_OF now being user selectable. Add a dependency on
> HAS_IOMEM to fix this.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/phy/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index cf18940..cb86d7a 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
>
> config MDIO_BUS_MUX_MMIOREG
> tristate "Support for MMIO device-controlled MDIO bus multiplexers"
> - depends on OF_MDIO
> + depends on OF_MDIO && HAS_IOMEM
> select MDIO_BUS_MUX
> help
> This module provides a driver for MDIO bus multiplexers that
> --
> 2.1.0
>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG
2015-07-05 17:16 [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG Rob Herring
2015-07-06 17:19 ` Florian Fainelli
@ 2015-07-08 21:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-07-08 21:11 UTC (permalink / raw)
To: robh; +Cc: f.fainelli, netdev
From: Rob Herring <robh@kernel.org>
Date: Sun, 5 Jul 2015 12:16:27 -0500
> On UML builds, mdio-mux-mmioreg.c fails to compile:
>
> drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>
> This is due to CONFIG_OF now being user selectable. Add a dependency on
> HAS_IOMEM to fix this.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-05 17:16 [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG Rob Herring
2015-07-06 17:19 ` Florian Fainelli
2015-07-08 21:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).