[PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

[PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

[Suman Tripathi]

This patch guards the acpi_evaluate_interger function as it fails
the build for CONFIG_ACPI=n.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
Signed-off-by: Suman Tripathi <stripathi@apm.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 4e83d4c..70b9ef6 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -871,6 +871,7 @@ static const struct net_device_ops xgene_ndev_ops = {
 	.ndo_set_mac_address = xgene_enet_set_mac_address,
 };

+#ifdef CONFIG_ACPI
 static int xgene_get_port_id_acpi(struct device *dev,
 				  struct xgene_enet_pdata *pdata)
 {
@@ -886,6 +887,7 @@ static int xgene_get_port_id_acpi(struct device *dev,

 	return 0;
 }
+#endif

 static int xgene_get_port_id_dt(struct device *dev, struct xgene_enet_pdata *pdata)
 {
--
1.8.2.1

Re: [PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

[David Miller]

From: Suman Tripathi <stripathi@apm.com>
Date: Mon,  6 Jul 2015 13:34:22 +0530

> This patch guards the acpi_evaluate_interger function as it fails
> the build for CONFIG_ACPI=n.
> 
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>

While the net-next tree is closed, all work and bug fixes should occur against
'net' which trumps the 'net-next' tree during this time.

If you had investigated, you would have seen that this build failure had
been fixed in the 'net' tree for some time now.