From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] rhashtable: fix for resize events during table walk Date: Wed, 08 Jul 2015 14:55:06 -0700 (PDT) Message-ID: <20150708.145506.1343225462680114617.davem@davemloft.net> References: <1436190680-21887-1-git-send-email-phil@nwl.cc> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tgraf@suug.ch, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, herbert@gondor.apana.org.au, daniel@iogearbox.net, geert@linux-m68k.org, mroos@linux.ee To: phil@nwl.cc Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:37780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbGHVzI (ORCPT ); Wed, 8 Jul 2015 17:55:08 -0400 In-Reply-To: <1436190680-21887-1-git-send-email-phil@nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: From: Phil Sutter Date: Mon, 6 Jul 2015 15:51:20 +0200 > If rhashtable_walk_next detects a resize operation in progress, it jumps > to the new table and continues walking that one. But it misses to drop > the reference to it's current item, leading it to continue traversing > the new table's bucket in which the current item is sorted into, and > after reaching that bucket's end continues traversing the new table's > second bucket instead of the first one, thereby potentially missing > items. > > This fixes the rhashtable runtime test for me. Bug probably introduced > by Herbert Xu's patch eddee5ba ("rhashtable: Fix walker behaviour during > rehash") although not explicitly tested. > > Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash") > Signed-off-by: Phil Sutter Applied and queued up for -stable, thanks.