From: David Miller <davem@davemloft.net>
To: sds@tycho.nsa.gov
Cc: jon.maloy@ericsson.com, ying.xue@windriver.com,
paul@paul-moore.com, linux-security-module@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/tipc: initialize security state for new connection socket
Date: Wed, 08 Jul 2015 16:08:55 -0700 (PDT) [thread overview]
Message-ID: <20150708.160855.1027366470220223329.davem@davemloft.net> (raw)
In-Reply-To: <1436276625-3325-1-git-send-email-sds@tycho.nsa.gov>
From: Stephen Smalley <sds@tycho.nsa.gov>
Date: Tue, 7 Jul 2015 09:43:45 -0400
> Calling connect() with an AF_TIPC socket would trigger a series
> of error messages from SELinux along the lines of:
> SELinux: Invalid class 0
> type=AVC msg=audit(1434126658.487:34500): avc: denied { <unprintable> }
> for pid=292 comm="kworker/u16:5" scontext=system_u:system_r:kernel_t:s0
> tcontext=system_u:object_r:unlabeled_t:s0 tclass=<unprintable>
> permissive=0
>
> This was due to a failure to initialize the security state of the new
> connection sock by the tipc code, leaving it with junk in the security
> class field and an unlabeled secid. Add a call to security_sk_clone()
> to inherit the security state from the parent socket.
>
> Reported-by: Tim Shearer <tim.shearer@overturenetworks.com>
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
> Acked-by: Paul Moore <paul@paul-moore.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-07-08 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 13:43 [PATCH] net/tipc: initialize security state for new connection socket Stephen Smalley
2015-07-08 5:09 ` Ying Xue
2015-07-08 23:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708.160855.1027366470220223329.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).