From: Felipe Balbi <balbi@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
Felipe Balbi <balbi@ti.com>, <stable@vger.kernel.org>
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr
Date: Wed, 8 Jul 2015 02:38:55 -0500 [thread overview]
Message-ID: <20150708073855.GA7277@saruman.tx.rr.com> (raw)
In-Reply-To: <1436338066-7685-1-git-send-email-mugunthanvnm@ti.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote:
> With the below commit, common isr is split into tx and rx, but in
> rx isr tx interrupt is also disabled. So tx packets are not handled
> during rx interrupts and rx napi completion. Fixing by disabling on
> rx interrupt in rx isr.
>
> Fixes: c03abd84634d ("net: ethernet: cpsw: don't requests IRQs we don't use")
why does this fix that commit ? What was the regression ? So RX IRQ fire
and both RX and TX are disabled, sure that's bad. But it should cause
lower throughput. At a minimum, I think your commit log needs some work.
Also, disable_irq_nosync() shouldn't really be needed, you could just
mask the IRQ in the IRQ Enable register, but I guess that'd be v4.3
material.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-08 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 6:47 [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr Mugunthan V N
2015-07-08 7:38 ` Felipe Balbi [this message]
2015-07-08 8:51 ` Mugunthan V N
2015-07-08 16:10 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708073855.GA7277@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).