From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: add SERDES registers to debugfs
Date: Wed, 8 Jul 2015 23:08:51 +0200 [thread overview]
Message-ID: <20150708210851.GI1357@lunn.ch> (raw)
In-Reply-To: <1436387779-23407-2-git-send-email-vivien.didelot@savoirfairelinux.com>
On Wed, Jul 08, 2015 at 04:36:19PM -0400, Vivien Didelot wrote:
> Add read and write access to a SERDES column in the regs debugfs file
> for the Fiber/SERDES registers.
Humm. I don't really like this. These SERDES registers are in a
complete different address space to the port, globalX registers. I
would suggest adding a new file, 'phy', which allows access to all the
phy registers, and SERDES at 0x0f.
This also makes it simpler to deal with devices which don't have
indirect access to the PHYs via Global 2 offset 0x18 and 0x19. For
such chips, the debugfs file should not be created.
Thanks
Andrew
next prev parent reply other threads:[~2015-07-08 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 20:36 [PATCH 1/2] net: dsa: mv88e6xxx: add write access to debugfs regs file Vivien Didelot
2015-07-08 20:36 ` [PATCH 2/2] net: dsa: mv88e6xxx: add SERDES registers to debugfs Vivien Didelot
2015-07-08 21:08 ` Andrew Lunn [this message]
2015-07-08 20:53 ` [PATCH 1/2] net: dsa: mv88e6xxx: add write access to debugfs regs file Andrew Lunn
2015-07-08 21:12 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708210851.GI1357@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).