From: David Miller <davem@davemloft.net>
To: sshah@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net 1/1] sfc: Report TX completions to BQL after all TX events in interrupt
Date: Thu, 09 Jul 2015 00:00:58 -0700 (PDT) [thread overview]
Message-ID: <20150709.000058.55757353896312409.davem@davemloft.net> (raw)
In-Reply-To: <559CE7C6.7040701@solarflare.com>
From: Shradha Shah <sshah@solarflare.com>
Date: Wed, 8 Jul 2015 10:05:10 +0100
> From: Peter Dunning <pdunning@solarflare.com>
>
> The limit for BQL is updated each time we call
> netdev_tx_completed_queue.
> Without this patch the BQL limit was updated for every TX event we
> see.
> The issue was that this only updated the limit to handle the data
> we complete in two events as the first event wouldn't show that
> enough traffic had been processed between them.
>
> This was OK when interrupt moderation was off but not when it was
> on as more data had to be completed in a single interrupt.
>
> The patch changes this so that we do report the completion to BQL
> only when all the TX events in the interrupt have been processed.
>
> Signed-off-by: Shradha Shah <sshah@solarflare.com>
Applied, thanks.
prev parent reply other threads:[~2015-07-09 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:05 [PATCH net 1/1] sfc: Report TX completions to BQL after all TX events in interrupt Shradha Shah
2015-07-09 7:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709.000058.55757353896312409.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).