From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org, balbi@ti.com, stable@vger.kernel.org
Subject: Re: [net PATCH v2 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr
Date: Thu, 09 Jul 2015 14:54:04 -0700 (PDT) [thread overview]
Message-ID: <20150709.145404.679352676923852906.davem@davemloft.net> (raw)
In-Reply-To: <1436346322-4455-1-git-send-email-mugunthanvnm@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Wed, 8 Jul 2015 14:35:22 +0530
> In commit 'c03abd84634d ("net: ethernet: cpsw: don't requests
> IRQs we don't use")', common isr is split into tx and rx, but
> in rx isr tx interrupt is also disabledi in cpsw_disable_irq().
> So tx interrupts are not handled during rx interrupts and rx
> napi completion and results in poor tx performance by 40Mbps.
> Fixing by disabling only rx interrupt in rx isr.
>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: <stable@vger.kernel.org> # v4.0+
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied, thanks.
prev parent reply other threads:[~2015-07-09 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:05 [net PATCH v2 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr Mugunthan V N
2015-07-09 21:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709.145404.679352676923852906.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=balbi@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).