netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pgynther@google.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors
Date: Thu, 09 Jul 2015 21:10:43 -0700 (PDT)	[thread overview]
Message-ID: <20150709.211043.898973722945548914.davem@davemloft.net> (raw)
In-Reply-To: <089e0122a88432eb63051a678bba@google.com>

From: Petri Gynther <pgynther@google.com>
Date: Thu, 09 Jul 2015 01:55:02 +0000

> bcmgenet driver needs to separate packet drops from packet errors.
> 
> When the driver has to drop a *good* packet, due to lack of buffers or
> replacement skbs, increment only dev->stats.[rx|tx]_dropped.
> 
> When the driver encounters a bad Rx packet or Tx error, increment only
> dev->stats.[rx|tx]_errors + relevant detailed error counter.
> 
> Signed-off-by: Petri Gynther <pgynther@google.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index b43b2cb..64c1e9d 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -1230,7 +1230,6 @@ static struct sk_buff
> *bcmgenet_put_tx_csum(struct net_device *dev,

This is severely corrupted by your email client.

Please fix this, email a test patch to yourself, and only resubmit
this patch to the mailing list if you can successfully apply the
patch you receive in that test email.

Thanks.

      parent reply	other threads:[~2015-07-10  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09  1:55 [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors Petri Gynther
2015-07-09  5:02 ` Florian Fainelli
2015-07-10  4:10 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150709.211043.898973722945548914.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pgynther@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).