From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bob.liu@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] bridge: fix potential crash in __netdev_pick_tx()
Date: Thu, 09 Jul 2015 22:49:21 -0700 (PDT) [thread overview]
Message-ID: <20150709.224921.97621113448468249.davem@davemloft.net> (raw)
In-Reply-To: <1436460967.24939.44.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 09 Jul 2015 18:56:07 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
> fixed an issue in normal forward path, caused by sender_cpu & napi_id
> skb fields being an union.
>
> Bridge is another point where skb can be forwarded, so we need
> the same cure.
>
> Bug triggers if packet was received on a NIC using skb_mark_napi_id()
>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Bob Liu <bob.liu@oracle.com>
> Tested-by: Bob Liu <bob.liu@oracle.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-07-10 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:26 BUG: unable to handle kernel NULL pointer in __netdev_pick_tx() Bob Liu
2015-07-06 10:41 ` Eric Dumazet
2015-07-06 11:13 ` Bob Liu
2015-07-06 17:36 ` Eric Dumazet
2015-07-09 16:56 ` [PATCH net] bridge: fix potential crash " Eric Dumazet
2015-07-10 5:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709.224921.97621113448468249.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bob.liu@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).